-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlay/15fcos: Print information regarding an ignition config and authorized keys #344
overlay/15fcos: Print information regarding an ignition config and authorized keys #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am uncomfortable with poking into all of /home
for the reasons below. I think it'd be safer instead if we changed afterburn and Ignition to write out "stamp files" like:
/var/lib/ignition/ssh-keys-written
/run/afterburn/ssh-keys-written
or so. Then all this service needs to do is run test -f
on those files, and it doesn't need any special privileges.
The downside of this approach is it requires patching those projects. For the Ignition case we discussed caching the config somewhere; if we did that we could just parse the config.
Maybe it's simplest to start with patching afterburn to write such a stamp file.
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-ssh-keys.service
Outdated
Show resolved
Hide resolved
Or, building on the idea from coreos/ignition#958 instead of the "stamp files" we could use a journal entry. |
We might as well make use of this. I thought of this while reviewing coreos/fedora-coreos-config#344
It looks like we need to cut a new release of coreos/ignition#958 |
Yeah, that's currently a manual process. |
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-user-config.service
Outdated
Show resolved
Hide resolved
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-ssh-keys.service
Outdated
Show resolved
Hide resolved
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-ssh-keys.service
Outdated
Show resolved
Hide resolved
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-ssh-keys.service
Outdated
Show resolved
Hide resolved
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-ssh-keys.service
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this was a long time coming. Nice work getting changes into all relevant upstreams and then bringing it all together here.
when I test this using /run/console-login-helper-messages/issue.d/30_ssh_authorized_keys.issue |
turned out to be https://github.com/coreos/fedora-coreos-config/pull/344/files#r429340945 |
…rized keys This PR addresses the concern raised in coreos/fedora-coreos-tracker#279 which talks about systems behavior when no igntion is provided. Currently, we're tracking ignitionConfig messages(coreos/fedora-coreos-tracker#279) and ssh-authorized keys info (coreos/afterburn#397) by sending the structured entry into journald log. Here, the systemd units are written to scrape through that information to display meaningful data to users.
ok all problems have been addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple spelling nits, FWIW.
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-ignition-config.service
Show resolved
Hide resolved
My bad. Thanks for point this out. I will create a follow-up PR to fix it. |
Follow-up to #344 (review)
Fixes #279
Note:
As per the resolution provided in the above issue(coreos/fedora-coreos-tracker#279 (comment)),