overlay: initramfs teardown: handle vlan devices during teardown #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
force-pushed
the
dusty-fix-vlan-teardown
branch
from
ed12fd1
to
7d0d429
Compare
|
example of this working: |
jlebon
approved these changes
Aug 5, 2020
| # If the device we're about to take down has disappeared | ||
| # since the start of this loop then skip taking it down. | ||
| if [ ! -e $f ]; then | ||
| echo "info: skipping teardown of ${interface}. It no longer exists." |
There was a problem hiding this comment.
Bikeshed:
Suggested change
| echo "info: skipping teardown of ${interface}. It no longer exists." | |
| echo "info: skipping teardown of ${interface}; no longer exists" |
to keep with the theme of single info sentences.
darkmuggle
approved these changes
Aug 5, 2020
When we are taking down network devices it's possible that taking down one will remove another (if they are connected in some way). This will cause the `down_interface()` call to fail if the device has already disappeared. Let's do another check to see if the device still exists right before trying to take it down. For an example of this failing. If we have kargs of ``` rd.neednet=1 vlan=vlan251:bond0 ip=192.168.122.111::192.168.122.1:255.255.255.0:initrdhost:vlan251:none:192.168.122.1 bond=bond0:ens2,ens3:mode=active-backup,miimon=100 ``` Then we have a vlan on top of a bond and we get an error during teardown: ``` [ 191.091838] coreos-teardown-initramfs[746]: info: taking down network device: ens2 [ 191.093836] coreos-teardown-initramfs[763]: RTNETLINK answers: Operation not supported [ 191.098439] coreos-teardown-initramfs[746]: info: taking down network device: ens3 [ 191.100318] coreos-teardown-initramfs[767]: RTNETLINK answers: Operation not supported [ 191.105143] coreos-teardown-initramfs[746]: info: taking down network device: vlan251 [ 191.110188] coreos-teardown-initramfs[772]: Cannot find device "vlan251" [ 191.114853] coreos-teardown-initramfs[775]: Cannot find device "vlan251" [ 191.117254] systemd[1]: coreos-teardown-initramfs.service: Control process exited, code=exited, status=1/FAILURE [ 191.119333] systemd[1]: coreos-teardown-initramfs.service: Failed with result 'exit-code'. ```
dustymabe
force-pushed
the
dusty-fix-vlan-teardown
branch
from
7d0d429
to
c0c5800
Compare
|
Addressed code review comments. Going through another round of testing real quick. |
|
Tests look good locally. The CI failure is because koji is under scheduled maintenance right now. |
|
Will merge when I can get CI green since the earlier code reviews were already ✅ |
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
Revert "kola-denylist: skip crio test on x86_64"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are taking down network devices it's possible that taking
down one will remove another (if they are connected in some way).
This will cause the
down_interface()call to fail if the devicehas already disappeared. Let's do another check to see if the device
still exists right before trying to take it down.
For an example of this failing. If we have kargs of
Then we have a vlan on top of a bond and we get an error during teardown: