ignition-ostree-rootfs: use our own tmpfs with size=80% #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need access to the platform ID, so just drop it.
We can just pass the path to `find` directly. Prep for next patch.
cgwalters
requested changes
Oct 14, 2020
overlay.d/05core/usr/lib/dracut/modules.d/40ignition-ostree/ignition-ostree-dracut-rootfs.sh
Outdated
Show resolved
Hide resolved
In f33 systemd, /run is now mounted with a smaller size cap instead of the default 50%: systemd/systemd#15424 This was causing the rootfs reprovisioning code to run out of space. Let's use this as an opportunity to be more explicit about the memory semantics we want. Notably, we don't care about starving the host here; either we have enough memory to reprovision the rootfs, or we should fail. So let's just mount our own tmpfs with `size=80%`. This in turn means that machines need even *less* RAM for rootfs reprovisioning to work. A local test shows 2.5G seems to be enough. Though let's keep recommending 4G in the docs to be safe. A minor thing this also fixes is that we now clean up a leftover directory and file from `/run` before we switchroot. Closes: coreos/fedora-coreos-tracker#644
jlebon
force-pushed
the
pr/run-mount-rootfs
branch
from
0690810
to
1c9a493
Compare
jlebon
changed the title
cgwalters
approved these changes
Oct 14, 2020
|
Thanks for tracking this down @jlebon |
10 tasks
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
25rhcos-azure-udev-rules: add 50-azure-ptp.rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f33 systemd, /run is now mounted with a smaller size cap instead of
the default 50%:
systemd/systemd#15424
This was causing the rootfs reprovisioning code to run out of space.
Let's use this as an opportunity to be more explicit about the memory
semantics we want. Notably, we don't care about starving the host here;
either we have enough memory to reprovision the rootfs, or we should
fail. So let's just mount our own tmpfs with
size=80%.This in turn means that machines need even less RAM for rootfs
reprovisioning to work. A local test shows 2.5G seems to be enough.
Though let's keep recommending 4G in the docs to be safe.
A minor thing this also fixes is that we now clean up a leftover
directory and file from
/runbefore we switchroot.Closes: coreos/fedora-coreos-tracker#644