35coreos-live/coreos-livepxe-rootfs: retry fetching rootfs forever #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to test this. |
dustymabe
reviewed
Apr 15, 2021
overlay.d/05core/usr/lib/dracut/modules.d/35coreos-live/coreos-livepxe-rootfs.sh
Outdated
Show resolved
Hide resolved
|
OK, tweaked and tested now! |
dustymabe
reviewed
Apr 15, 2021
overlay.d/05core/usr/lib/dracut/modules.d/35coreos-live/coreos-livepxe-rootfs.sh
Outdated
Show resolved
Hide resolved
bgilbert
previously approved these changes
Apr 15, 2021
overlay.d/05core/usr/lib/dracut/modules.d/35coreos-live/coreos-livepxe-rootfs.sh
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/lib/dracut/modules.d/35coreos-live/coreos-livepxe-rootfs.sh
Outdated
Show resolved
Hide resolved
We don't know how long it will take for networking to come up, so let's match Ignition's semantic of retrying to fetch remote resources forever. `curl` doesn't natively have support for this, so wrap it in a `while` loop. This also works around the fact that el8's `curl` doesn't support `--retry-all-errors`. This was previously added in coreos#929.
jlebon
added a commit
to jlebon/os
that referenced
this pull request
Apr 16, 2021
For coreos/fedora-coreos-config#964 for https://gitlab.cee.redhat.com/coreos/redhat-coreos/-/merge_requests/1252#note_2289576. ``` Dusty Mabe (5): manifests: f34: Delete coreos-reset-stub-resolv-selinux-context.{path,service}. overrides: drop kernel 5.10.19 freeze overrides: drop graduated podman override overlay.d/35coreos-network: handle new nm-run.service in initramfs overlay.d/35coreos-network: don't bring up NM if not needed Jonathan Lebon (3): tests/kola/rootless-systemd: add back sleep overrides: fast-track rpm-ostree-2021.4 35coreos-live/coreos-livepxe-rootfs: retry fetching rootfs forever Luca BRUNO (1): manifest-lock: drop graduated overrides Miroslav Lichvar (1): overlay.d/20platform-chrony: Fix misconfiguration with leap-smearing servers Timothée Ravier (2): tests/kola/rpm-ostree-countme: Update for pre-release repo count tests/kola/toolbox: Retry 'toolbox create' to avoid infra flakes ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't know how long it will take for networking to come up, so let's
match Ignition's semantic of retrying to fetch remote resources forever.
curldoesn't natively have support for this, so wrap it in awhileloop. This also works around the fact that el8's
curldoesn't support--retry-all-errors.This was previously added in #929.