Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook events from coreos/fedora-coreos-streams to prod Jenkins failing with "Error 400 Provided signature [...] did not match to calculated" #352

Closed
jlebon opened this issue Jun 15, 2021 · 7 comments
Closed

Webhook events from coreos/fedora-coreos-streams to prod Jenkins failing with "Error 400 Provided signature [...] did not match to calculated" #352

jlebon opened this issue Jun 15, 2021 · 7 comments

Comments

@jlebon
Copy link
Member

jlebon commented Jun 15, 2021 

<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 400 Provided signature [<hash>] did not match to calculated</title>
</head>
<body><h2>HTTP ERROR 400 Provided signature [<hash>] did not match to calculated</h2>
<table>
<tr><th>URI:</th><td>/github-webhook/</td></tr>
<tr><th>STATUS:</th><td>400</td></tr>
<tr><th>MESSAGE:</th><td>Provided signature [<hash>] did not match to calculated</td></tr>
<tr><th>SERVLET:</th><td>Stapler</td></tr>
</table>
<hr><a href="https://eclipse.org/jetty">Powered by Jetty:// 9.4.33.v20201020</a><hr/>

</body>
</html>
@jlebon
Copy link
Member Author

jlebon commented Jun 15, 2021

OK yup, looks like fallout from jenkinsci/github-plugin#242, which was reverted in jenkinsci/github-plugin#246, which is in the Github plugin v1.33.1. We're at v1.33.0. Let's update it.

jlebon added a commit to jlebon/jenkins that referenced this issue Jun 15, 2021
@jlebon
base-plugins: bump github to 1.33.1
98ab7b2 
v1.33.0 has a regression breaking GitHub webhooks. It was fixed in
v1.33.1:

jenkinsci/github-plugin#242

This is the only change in v1.33.1 so should be safe:

jenkinsci/github-plugin@v1.33.0...v1.33.1

See also: coreos/fedora-coreos-pipeline#352
@jlebon jlebon mentioned this issue Jun 15, 2021
Closed
@jlebon
Copy link
Member Author

jlebon commented Jun 15, 2021

Let's see if we can fix it in the source image itself: openshift/jenkins#1279. If it takes too long, we can bump it here in the interim.

@dustymabe
Copy link
Member

dustymabe commented Sep 1, 2021 •
edited

hit this in coreos-ci today. Yesterday I had to restart it and use emptyDir to get it running because of https://pagure.io/centos-infra/issue/423 (we'll need to get the PVC unbound before we can switch back to actual storage) so it was started from scratch.

Do we need to apply openshift/jenkins#1279 to coreos-ci repo ?

@cgwalters
Copy link
Member

Heh awesome. Short term, perhaps we can just strip all unicode from our repo descriptions? I would be very sad, but I am more sad about CI not working.

@dustymabe
Copy link
Member

(we'll need to get the PVC unbound before we can switch back to actual storage)

also reminder here that because of https://pagure.io/centos-infra/issue/423 I applied a nodeSelector to our jenkins container definition so it wouldn't select the bad node (and thus never come up). Let's remove the nodSelector from the container definition when we move it back to being backed by the PV (and thus are doing a restart anyway).

jlebon added a commit to jlebon/fedora-coreos-pipeline that referenced this issue Sep 13, 2021
@jlebon
plugins: bump github to 1.33.1
98298f5 
It contains a fix for coreos#352. Once the base Jenkins imagestream is updated
in our cluster, we can drop this so we don't lock on 1.33.1.
@jlebon jlebon mentioned this issue Sep 13, 2021
Merged
jlebon added a commit that referenced this issue Sep 13, 2021
@jlebon
plugins: bump github to 1.33.1
bd494bf 
It contains a fix for #352. Once the base Jenkins imagestream is updated
in our cluster, we can drop this so we don't lock on 1.33.1.
@jlebon
Copy link
Member Author

jlebon commented Sep 13, 2021

1.33.1 is now on CoreOS CI.

Trying to roll this out to the pipeline, though hitting some dependency issues.

@jlebon
Copy link
Member Author

jlebon commented Sep 13, 2021

Need #395 but otherwise this is fixed.

@jlebon jlebon closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgwalters @dustymabe @jlebon