jobs/build-arch: add s390x spec #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to run s390x builds. Right now limited to just the qemu image.
jlebon
approved these changes
May 31, 2022
| @@ -331,7 +331,34 @@ stages: | |||
| delay_meta_merge: false | |||
| EOF | |||
| """) | |||
| gp.gangplankArchWrapper([spec: "spec.spec", arch: basearch, image: image]) | |||
| shwrap(""" | |||
| cat <<'EOF' > spec-s390x.spec | |||
There was a problem hiding this comment.
I'm OK with this, but I think it'd be neater if we refactored things a bit so that everything in common is written just once and then anything arch-specific is done separately. Then in the future, arch-specific things will keep getting smaller.
There was a problem hiding this comment.
agree. I think if we end up ripping out gangplank (coreos/coreos-assembler#2860) we'll be refactoring this quite a bit anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to run s390x builds. Right now limited to just
the qemu image.