jobs/{build,build-arch}: don't run metal4k tests on s390x #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
approved these changes
Jul 22, 2022
| } | ||
| if (basearch != "s390x") { |
There was a problem hiding this comment.
LGTM as is but: I think the right long term direction is to encode this knowledge in coreos-assembler. (It's what gangplank was also trying to do to a degree)
There was a problem hiding this comment.
yeah I think we reached out to someone recently to find out if we should stop building the 4k metal images on s390x at all.
Tracking in coreos/fedora-coreos-tracker#1261 - which I should probably also link to here in the code. Let add that.
The 4k disk doesn't work right now. See coreos/fedora-coreos-tracker#1261 Also rework a bit the structure of the "parallel" invocation for testiso.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rework a bit the structure of the "parallel" invocation
for testiso.