Revert "jenkins/config: bump kubernetes-plugin maxRequestsPerHost" #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc35327. The intention is good, but we can't do this via JCASC because it clobbers the existing `openshift` cloud configuration instead of merging it in.
|
We'll have to figure out how to do this some other way. |
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Aug 3, 2022
By default, when using a PVC, the OpenShift S2I Jenkins image only instantiates templates on the first run. This however means that configuration state can accumulate in the PVC. Set the `OVERRIDE_PV_CONFIG_WITH_IMAGE_CONFIG` env var which tells the S2I run script to always instantiate and copy in templates. This *should* preserve build logs. An example of this is the Kubernetes cloud config, which was lost in a recent change (see coreos#583).
jlebon
added a commit
that referenced
this pull request
Aug 3, 2022
By default, when using a PVC, the OpenShift S2I Jenkins image only instantiates templates on the first run. This however means that configuration state can accumulate in the PVC. Set the `OVERRIDE_PV_CONFIG_WITH_IMAGE_CONFIG` env var which tells the S2I run script to always instantiate and copy in templates. This *should* preserve build logs. An example of this is the Kubernetes cloud config, which was lost in a recent change (see #583).
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Dec 6, 2022
This is a conceptual revert of the revert in coreos#583. Now that we own the cloud config, we can safely do this.
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Dec 6, 2022
This is a conceptual revert of the revert in coreos#583. Now that we own the cloud config, we can safely do this.
|
This is reverted again in #783 |
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Dec 7, 2022
This is a conceptual revert of the revert in coreos#583. Now that we own the cloud config, we can safely do this.
jlebon
added a commit
that referenced
this pull request
Dec 7, 2022
This is a conceptual revert of the revert in #583. Now that we own the cloud config, we can safely do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fc35327.
The intention is good, but we can't do this via JCASC because it
clobbers the existing
openshiftcloud configuration instead of mergingit in.