Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: add trySlackSend() function, use it across the tree #657

Closed
wants to merge 1 commit into from

Conversation

dustymabe
Copy link
Member

This will make sending a slack message conditional on if the credential exists.

This will make sending a slack message conditional on if the credential
exists.
@dustymabe
Copy link
Member Author

broken out from #656 for us to consider later

@jlebon
Copy link
Member

jlebon commented Sep 30, 2022

If the goal is to make it easier to use Slack from non-official pipelines, I'd say we should make the room a config knob instead, which we can do by removing room from slack.yaml, add it to config.yaml, and pass it when calling slackSend.

And possibly refuse to post to Slack if the official channel name is used in non-official.

@dustymabe
Copy link
Member Author

Something like this was merged in 33a1a58

@dustymabe dustymabe closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants