Add replication to clouds #746
Conversation
ravanelli
force-pushed
the
replicate
branch
2 times, most recently
from
328d7bc
to
513785e
Compare
| if (c.regions) { | ||
| regions = c.regions.join(" ") | ||
| } |
There was a problem hiding this comment.
I wonder if it's possible to autodetect here like we do for the other clouds?
There was a problem hiding this comment.
I'm still waiting for a test secret to see how things go. =/. I will try as son as I got it.
There was a problem hiding this comment.
Let's not wait on the credentials for this. Let's leave this code in for now but also document it in docs/config.yaml. We can post any followup fixes/improvements that we find in the coming days.
I'd like to get this PR merged sooner than later so we can start really testing it out (in the FCOS pipeline).
|
As part of this PR we probably need to do two other things:
|
- Add cloud replication for aws, aliyun and powervs in case it is present in the meta.json Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Add `--public` parameter for Aliyun cloud upload; - Update documentation to reflect the change. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Rename file for accuracy; - Update files using the old libupload call. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Rename parameter for accuracy; Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Drop code and use replicate_to_clouds function instead. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
| if (c.regions) { | ||
| regions = c.regions.join(" ") | ||
| } |
There was a problem hiding this comment.
Let's not wait on the credentials for this. Let's leave this code in for now but also document it in docs/config.yaml. We can post any followup fixes/improvements that we find in the coming days.
I'd like to get this PR merged sooner than later so we can start really testing it out (in the FCOS pipeline).
libupload.groovy
Outdated
| --bucket-prefix ${c.bucket} \ | ||
| --regions ${regions} \ | ||
| --credentials-file \${"POWER_IMAGE_UPLOAD_CONFIG"} \ | ||
| --force |
There was a problem hiding this comment.
I think we should probably remove the --force here and in the upload_to_clouds() function below. In the new pipeline structure we just allocate a new build ID typically.
- Remove force option in libcloud; - Update documentation about powervs regions. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
No description provided.