Support skipping or overriding additional arches per stream #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: #740 |
dustymabe
reviewed
Nov 9, 2022
Comment on lines
+79
to
+80
| skip_additional_arches: | ||
| - s390x |
There was a problem hiding this comment.
The use of the term additional in the toplevel key makes this key confusing. I would almost expect it to be skip_arches and not skip_additional_arches, but I understand tying it back to the name of the toplevel key.
I almost wonder if secondary_arches should be the toplevel key.
There was a problem hiding this comment.
Yeah, it's a bit awkward but I wanted to be consistent with the naming. It also conveys a bit more the fact that you can't skip x86_64, only arches that are valid in additional_arches.
Switching to secondary would indeed read a bit better I think. Let's do that in a follow-up?
jlebon
force-pushed
the
pr/skip-arches
branch
from
567144c
to
34e6ed8
Compare
Add support for `skip_additional_arches` and `additional_arches` keys in the stream-level section. E.g. currently for FCOS, we're not shipping ppc64le for the production streams. This will also be useful for RHCOS in the future when e.g. keeping older streams alive on only a subset of arches.
jlebon
force-pushed
the
pr/skip-arches
branch
from
34e6ed8
to
6a6c71e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
skip_additional_archesandadditional_archeskeys inthe stream-level section. E.g. currently for FCOS, we're not shipping
ppc64le for the production streams.
This will also be useful for RHCOS in the future when e.g. keeping older
streams alive on only a subset of arches.