jobs/build: add EARLY_ARCH_JOBS parameter #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
force-pushed
the
dusty-early-arch-jobs
branch
from
59c3ee9
to
d1f8b73
Compare
|
Of course, we can bikeshed on the parameter name. |
This will give us control of when the multi-arch jobs are kicked off. In some cases we want them to be kicked off early (to save time). Unfortunately in that case if the x86_64 build later fails (which means the build ID can no longer be used) the work done by the multi-arch builds gets trashed as well. Let's add a knob so we can kick them off early when desired, but allow for them to be kicked off later in situations where time isn't a large factor.
dustymabe
force-pushed
the
dusty-early-arch-jobs
branch
from
d1f8b73
to
97f742a
Compare
jlebon
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
We discussed this OOB. It's hard to evaluate the complexity increase here against the slight semantic change. I'm good with this but I think we should investigate replacing it with something that aborts the builds instead (similar to the milestone plugin but that actually works across different jobs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give us control of when the multi-arch jobs are kicked off. In some cases we want them to be kicked off early (to save time). Unfortunately in that case if the x86_64 build later fails (which means the build ID can no longer be used) the work done by the multi-arch builds gets trashed as well.
Let's add a knob so we can kick them off early when desired, but allow for them to be kicked off later in situations where time isn't a large factor.