Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: include catch/finally in cosaPod() block #763

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

dustymabe
Copy link
Member

Also includes some re-organization/comment fixes.

commit 1fae67e20a7590c94582ece82b18d76617c5eb35
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Nov 18 16:12:22 2022 -0500

    jobs/kola-*: include catch/finally in cosaPod() block
    
    This will allow us to do more advanced things in the finally. For
    example the `oc` command that got added to `trySlackSend()` in
    4404730 needs to run from inside the cosaPod to work.

commit 8f10e97480d7313253724d648d902516a88c64ed
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Nov 18 16:07:54 2022 -0500

    jobs/kola-openstack: fix comments move around variables
    
    The comment was outdated since we aren't running tests on multiple
    regions any longer.
    
    Moved around the variables to prep for the next patch.

commit a8ffb28e69aaa39bd061e6dd770ae58fb0740330
Author: Dusty Mabe <dusty@dustymabe.com>
Date:   Fri Nov 18 15:56:42 2022 -0500

    jobs/kola-azure: remove locking
    
    This was copy/pasted from the openstack job and doesn't apply
    to Azure. This is obvious because azure doesn't even test on multiple
    architectures at the moment.

This was copy/pasted from the openstack job and doesn't apply
to Azure. This is obvious because azure doesn't even test on multiple
architectures at the moment.
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the commit title for the second commit supposed to be

jobs/kola-openstack: fix comments and move around variables

?

@dustymabe dustymabe changed the title jobs/kola-*: include catch/finally in cosaPod() block tree-wide: include catch/finally in cosaPod() block Nov 18, 2022
The comment was outdated since we aren't running tests on multiple
regions any longer.

Moved around the variables to prep for the next patch.
This will allow us to do more advanced things in the finally. For
example the `oc` command that got added to `trySlackSend()` in
4404730 needs to run from inside the cosaPod to work.
@dustymabe
Copy link
Member Author

LGTM. Is the commit title for the second commit supposed to be

jobs/kola-openstack: fix comments and move around variables

?

Yeah - fixed.

@dustymabe
Copy link
Member Author

I added more files to the last commit as I realized I needed to do the same thing for bump-lockfile build-cosa and build-fcos-buildroot

@dustymabe dustymabe merged commit e6be06f into coreos:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants