Some follow-ups to Slack prefixing work #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current namespace is implied so there's no need to specify it. This also works around the fact that `env.PROJECT_NAME` is only defined when running directly on the controller, which is not the case in the paths in which `getSlackEmojiPrefix()` is currently called.
Run the pods we provision with the same service account as the one Jenkins itself runs with. This should probably be something done by default by the kubernetes-plugin, but surprisingly AFAICT there are no knobs for this. Anyway, in the future we could look at "usptreaming" this into coreos-ci-lib directly, though I need to look into what's the cleanest way to introspect the service account being used in a generic way. This fixes the fact that with the default SA, we can't actually query annotations from the Slack secret for getting the emoji prefix to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.