jobs: pass fully qualified ref name to git ls-remote
#840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we risk getting multiple refs matching the given pattern (i.e. the branch name showing up in more branches than just the canonical branch). We hit this today with a revert branch that was auto-created accidentally by GitHub through the web UI: ``` $ git ls-remote https://github.com/coreos/fedora-coreos-config next b9f8903339c142b00105bd0fb97c3fcc21e1502a refs/heads/next 9007e5804e41097afaa7e42d13455d8a8cd87375 refs/heads/revert-2307-bootloader/next ``` And then the `src_config_commit` variable had multiple lines which messed up parameter substitution lower down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we risk getting multiple refs matching the given pattern (i.e. the branch name showing up in more branches than just the canonical branch). We hit this today with a revert branch that was auto-created accidentally by GitHub through the web UI:
And then the
src_config_commitvariable had multiple lines which messed up parameter substitution lower down.