Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package Request: zstd #1251

Closed
bgilbert opened this issue Jul 12, 2022 · 7 comments · Fixed by coreos/fedora-coreos-config#1843
Closed

New Package Request: zstd #1251

bgilbert opened this issue Jul 12, 2022 · 7 comments · Fixed by coreos/fedora-coreos-config#1843

Comments

@bgilbert
Copy link
Contributor

Please try to answer the following questions about the package you are requesting:

  1. What, if any, are the additional dependencies on the package? (i.e. does it pull in Python, Perl, etc)

None.

  1. What is the size of the package and its dependencies?
$ rpm -q --queryformat '%{SIZE}\n' zstd-1.5.2-2.fc36.x86_64
1608976
  1. What problem are you trying to solve with this package? Or what functionality does the package provide?

Create initrd images with zstd compression, which would improve boot time and reduce initrd size.

  1. Can the software provided by the package be run from a container? Explain why or why not.

In general, yes, but not for initrd creation.

  1. Can the tool(s) provided by the package be helpful in debugging container runtime issues?

No.

  1. Can the tool(s) provided by the package be helpful in debugging networking issues?

No.

  1. Is it possible to layer the package onto the base OS as a day 2 operation? Explain why or why not.

No, zstd needs to be available during cosa build.

  1. In the case of packages providing services and binaries, can the packaging be adjusted to just deliver binaries?

There are no services.

  1. Can the tool(s) provided by the package be used to do things we’d rather users not be able to do in FCOS? (e.g. can it be abused as a Turing complete interpreter?)

No.

  1. Does the software provided by the package have a history of CVEs?

Yes: CVE-2019-11922, CVE-2021-24031, CVE-2021-24032.

@cgwalters
Copy link
Member

Big 👍 from me! zstd is the clear successor to gzip we should use by default.

@cgwalters
Copy link
Member

(Tangentially related to this...OCI containers default to gzip, but as of relatively recently also support zstd, and at some point hopefully in...well let's be realistic two years...we can cut over our containers to use that)

@jlebon
Copy link
Member

jlebon commented Jul 13, 2022

Stating the obvious but: note this add 1.5M, but reduces the initrd by ~15M. The initrd appears once in OSTrees, and twice in disk images. Compressed disk images should have a decent size reduction from this.

@jlebon
Copy link
Member

jlebon commented Jul 13, 2022

This was discussed in today's FCOS community meeting:

12:50:34 < bgilbert> #agreed We will add the zstd package to FCOS, and switch our initrd to use it.

@jlebon jlebon added status/pending-action Needs action and removed meeting topics for meetings labels Jul 13, 2022
dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this issue Jul 13, 2022
We'll soon use this to compress our initrds.

Fixes coreos/fedora-coreos-tracker#1251.
@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. and removed status/pending-action Needs action labels Jul 19, 2022
@dustymabe
Copy link
Member

The fix for this went into next stream release 36.20220716.1.0. Please try out the new release and report issues.

@dustymabe
Copy link
Member

The fix for this went into testing stream release 36.20220716.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. labels Jul 19, 2022
@dustymabe
Copy link
Member

The fix for this went into stable stream release 36.20220716.3.1.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Jul 28, 2022
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
We'll soon use this to compress our initrds.

Fixes coreos/fedora-coreos-tracker#1251.
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
We'll soon use this to compress our initrds.

Fixes coreos/fedora-coreos-tracker#1251.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants