Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F38 Change: Shorter Shutdown Timer #1404

Closed
dustymabe opened this issue Feb 1, 2023 · 8 comments
Closed

F38 Change: Shorter Shutdown Timer #1404

dustymabe opened this issue Feb 1, 2023 · 8 comments
Assignees

Comments

@dustymabe
Copy link
Member

For the proposed Fedora 38 changes we decided to discuss further the following change:

  • Shorter Shutdown Timer
    • A downstream configuration change to reduce the systemd unit timeout from 2 minutes to 45 seconds and send SIGABRT to generate a core dump before SIGKILL.
    • Tracking bug: #2161753
    • NOTES: DM: We will need to consider the shutdown timeout change and if we want to accept it or add our own configuration override.
@cgwalters
Copy link
Member

I think we should not make this change for Fedora CoreOS. I commented on the list https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/K7YXBE35NJZIA5TGDC5OPNZHU6SWGE5N/

@travier
Copy link
Member

travier commented Feb 6, 2023

I agree as well that we should not make this change for FCOS, which means that we'll have to make sure to reset the setting to the default.

@travier
Copy link
Member

travier commented Feb 8, 2023

As this is set by default at compile time, we'll have to ship a config to revert it.

@jlebon
Copy link
Member

jlebon commented Feb 8, 2023

We discussed this in today's community meeting:

  * AGREED: we do not want this change in FCOS. we think other server
    variants don't as well. we will submit a PR against fedora-release
    to undo this change on server variants to try to push the
    conversation forward.  (jlebon, 17:05:52)

@jlebon jlebon removed the meeting topics for meetings label Feb 8, 2023
@travier travier self-assigned this Feb 15, 2023
@travier
Copy link
Member

travier commented Feb 16, 2023

PR in: https://src.fedoraproject.org/rpms/fedora-release/pull-request/249

Feel free to ping folks from other editions there a I'm not sure exactly who to ping.

@travier
Copy link
Member

travier commented Feb 16, 2023

It would be nice to have a test for it. It should be easy to make by checking systemctl show values.

@travier travier assigned Adam0Brien and unassigned travier Feb 16, 2023
@travier
Copy link
Member

travier commented Feb 16, 2023

I've manually tested the RPM. I'll let Adam write the kola test.

Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-config that referenced this issue Feb 20, 2023
Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-config that referenced this issue Feb 20, 2023
Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-config that referenced this issue Feb 21, 2023
Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-config that referenced this issue Feb 22, 2023
@jlebon
Copy link
Member

jlebon commented Mar 1, 2023

We discussed this in today's community meeting:

  • AGREED: we will get the fedora-release MR merged which currently only affects FCOS for now so that we can include it and verify it (jlebon, 17:08:41)

Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-config that referenced this issue Mar 7, 2023
Adam0Brien pushed a commit to Adam0Brien/fedora-coreos-config that referenced this issue Mar 7, 2023
qinqon pushed a commit to qinqon/rpms-fedora-release that referenced this issue Mar 16, 2023
Reset the default timeout to systemd upstream defaults for the following
Fedora editions/variants:
 - Fedora CoreOS

See:
- Fedora Change: https://fedoraproject.org/wiki/Changes/Shorter_Shutdown_Timer
- Upstream systemd change: systemd/systemd#26242
- Fedora systemd change: https://src.fedoraproject.org/rpms/systemd/c/ba02e904964116b848080ca72243174f4ef3eced?branch=rawhide
- Discussion for Fedora CoreOS: coreos/fedora-coreos-tracker#1404
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants