Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed unit : rpm-ostree-fix-shadow-mode.service #1722

Closed
Nemric opened this issue Apr 30, 2024 · 11 comments · Fixed by coreos/rpm-ostree#4944
Closed

Failed unit : rpm-ostree-fix-shadow-mode.service #1722

Nemric opened this issue Apr 30, 2024 · 11 comments · Fixed by coreos/rpm-ostree#4944
Labels

Comments

@Nemric
Copy link

Nemric commented Apr 30, 2024

Describe the bug

Booting a next stream FCOS 40 I can see when login to node :

[systemd]
Failed Units: 1
  rpm-ostree-fix-shadow-mode.service

I'm using a diskless PXE provisionned machine

I have this logs

journalctl -eu rpm-ostree-fix-shadow-mode.service
Apr 30 17:30:45 Turing systemd[1]: Starting rpm-ostree-fix-shadow-mode.service - Update permissions for /etc/shadow...
Apr 30 17:30:45 Turing rpm-ostree[1250]: error: Read-only file system
Apr 30 17:30:45 Turing systemd[1]: rpm-ostree-fix-shadow-mode.service: Main process exited, code=exited, status=1/FAILURE
Apr 30 17:30:45 Turing systemd[1]: rpm-ostree-fix-shadow-mode.service: Failed with result 'exit-code'.
Apr 30 17:30:45 Turing systemd[1]: Failed to start rpm-ostree-fix-shadow-mode.service - Update permissions for /etc/shadow.

Reproduction steps

Boot from PXE with http ign provisionning

Expected behavior

No failed units

Actual behavior

Failed Unit

System details

Bare metal PXE booted and provisonned node

Butane or Ignition config

No response

Additional information

No response

@jmarrero
Copy link
Member

jmarrero commented Apr 30, 2024

looking at https://docs.fedoraproject.org/en-US/fedora-coreos/live-booting/#_booting_via_iso
if that is how we support diskless systems, maybe we should check for the coreos.liveiso.fromram karg before starting the service.

@Nemric
Copy link
Author

Nemric commented Apr 30, 2024

I'm using this https://docs.fedoraproject.org/en-US/fedora-coreos/live-booting/#_booting_via_pxe
A mix between pxe and ipxe, but that works fine
Do we need this service to run as it seems to be here for updating an installed FCOS ?
I think the shadow mode is correct on a stock pxe booted node isn't it ?

@jlebon
Copy link
Member

jlebon commented Apr 30, 2024

Yeah, I think we basically just need a ConditionPathExists=!/run/ostree-live in that unit.

Or... maybe ConditionKernelCommandLine=ostree would be more accurate. /run/ostree-live, while it sounds like an ostree thing, is actually written by CoreOS code. Whereas ConditionKernelCommandLine=ostree is pretty canon and a more generic fix.

@dustymabe
Copy link
Member

Upstream fix in coreos/rpm-ostree#4944

@dustymabe dustymabe added the status/pending-upstream-release Fixed upstream. Waiting on an upstream component source code release. label May 2, 2024
@dustymabe dustymabe reopened this May 5, 2024
@Nemric
Copy link
Author

Nemric commented May 21, 2024

Did this PR was merged into current (40.20240519.1.0) "next stream" ? I still see this failed service :/

@jlebon
Copy link
Member

jlebon commented May 22, 2024

Did this PR was merged into current (40.20240519.1.0) "next stream" ? I still see this failed service :/

It just made it into a new rpm-ostree release. It should show up in the next releases of next and testing.

@Nemric
Copy link
Author

Nemric commented Jun 20, 2024

Ok, works great on 40.20240616.1.0 (mid june next stream)
Is there something else to check before closing this issue ? Like ... is "rpm-ostree-shadow-mode" fixed ^^

@jbtrystram
Copy link
Contributor

You can look that the permissions on /etc/shadow are correct (600)
On live systems it doesn't matter that's why we disabled it.

@Nemric Nemric closed this as completed Jun 21, 2024
@travier
Copy link
Member

travier commented Jun 24, 2024

This landed in rpm-ostree 2024.6 which landed in Fedora CoreOS next in 40.20240616.1.0, testing in 40.20240616.2.0. It's not yet in stable.

@travier travier added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-upstream-release Fixed upstream. Waiting on an upstream component source code release. labels Jun 24, 2024
marmijo added a commit to marmijo/fedora-coreos-streams that referenced this issue Jun 27, 2024
includes updates for the following:
   - 2024-05-21:
	- coreos/fedora-coreos-tracker#1653
   - 2024-06-03
   - 2024-06-17:
	- coreos/fedora-coreos-tracker#1722
marmijo added a commit to marmijo/fedora-coreos-streams that referenced this issue Jun 27, 2024
includes updates for the following:
   - 2024-05-21:
	- coreos/fedora-coreos-tracker#1653
   - 2024-06-03
   - 2024-06-17:
	- coreos/fedora-coreos-tracker#1722
marmijo added a commit to marmijo/fedora-coreos-streams that referenced this issue Jun 27, 2024
includes updates for the following:
   - 2024-05-21:
	- coreos/fedora-coreos-tracker#1653
   - 2024-06-03
   - 2024-06-17:
	- coreos/fedora-coreos-tracker#1722
marmijo added a commit to coreos/fedora-coreos-streams that referenced this issue Jun 27, 2024
includes updates for the following:
   - 2024-05-21:
	- coreos/fedora-coreos-tracker#1653
   - 2024-06-03
   - 2024-06-17:
	- coreos/fedora-coreos-tracker#1722
@marmijo
Copy link
Contributor

marmijo commented Jul 8, 2024

The fix for this went into stable stream release 40.20240616.3.0. Please try out the new release and report issues.

@marmijo marmijo removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Jul 8, 2024
@jbtrystram
Copy link
Contributor

I booted a liveISO of 40.20240616.3.0 yesterday and did not see the message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants