Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Add section on FCC/FCCT/FCCL #175

Merged
merged 1 commit into from
May 3, 2019
Merged

Design: Add section on FCC/FCCT/FCCL #175

merged 1 commit into from
May 3, 2019

Conversation

ajeddeloh
Copy link
Contributor

@ajeddeloh ajeddeloh commented May 1, 2019 •
edited
Loading

Addresses #129
Closes #89

rfairley
rfairley reviewed May 3, 2019
View reviewed changes
Copy link

@rfairley rfairley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

Design.md Outdated Show resolved Hide resolved
jlebon
jlebon reviewed May 3, 2019
View reviewed changes
Design.md Outdated Show resolved Hide resolved
@jlebon jlebon merged commit 004def8 into coreos:master May 3, 2019
arithx
arithx approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajeddeloh ajeddeloh mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon left review comments

@rfairley rfairley rfairley left review comments

@arithx arithx arithx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FCOS config versioning
4 participants
@ajeddeloh @arithx @jlebon @rfairley