Add iptables rule to prevent masquerade on some external traffic #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that was preventing OnlyLocal annotation in Kubernetes from working correctly. Prevents masquerade on external traffic to containers/pods in the subnet. Fixes flannel-io#734
|
This looks good to me. @ironlung975 what sort of testing have you done on this? |
|
@caseydavenport Just ran the go tests and ran this locally in flannel. I'm currently fixing some issues with my kubernetes test setup but that's the last thing I have planned for testing. |
|
@caseydavenport got my tests working in kubernetes. Looks like this should be good to go from what I can tell. |
|
LGTM |
chenchun
added a commit
to chenchun/flannel
that referenced
this pull request
Aug 11, 2020
…vice.spec.externalTrafficPolicy=Local
chenchun
pushed a commit
to chenchun/flannel
that referenced
this pull request
Aug 11, 2020
Cherry-pick flannel-io#745 to fix preserving client ip if setting service.spec.externalTrafficPolicy=Local Cherry-pick flannel-io#745 to fix preserving client ip if setting service.spec.externalTrafficPolicy=Local See merge request !22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug that was preventing OnlyLocal annotation in Kubernetes
from working correctly. Prevents masquerade on external traffic to
containers/pods in the subnet.
Fixes #734