This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Migrate from "github.com/kr/pty" to "github.com/creack/pty" #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyfok
force-pushed
the
migrate-to-github.com-creack-pty-for-go1.15
branch
from
fba5c81
to
88b184e
Compare
Fixes "Setctty set but Ctty not valid in child" error with Go 1.15 and up. See creack/pty#96 for details.
anthonyfok
force-pushed
the
migrate-to-github.com-creack-pty-for-go1.15
branch
from
88b184e
to
3cb47f4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Setctty set but Ctty not valid in child with Go" error
with Go 1.15 and up. See creack/pty#96