-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go.mod & main.go errors #4
Conversation
Notably the top level files do specify the package name as |
Just to clarify: importing
No problem so I import importing `github.com/coreos/ign-converter/ign2to3 : pulls in some stuff/updates my go.sum I think that this is a relic from when the repo was called ign2to3? if module path was correct as |
I'm not a golang expert by any means, but yeah it'd be less confusing to just match the package name with the module name and the repo name. |
Ok so i redid the go.mod file which hadn't been updated in a long time. I'm unsure what this main.go function is, but it had some problems even running go build ie import issues and golang error, which i also fixed. Unit tests still pass as well. |
cc: @yuqi-zhang |
e808fcb
to
40f8e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minors but otherwise LGTM
also update ign2to3 pkg name to ignconverter, since it does more than 2to3
update dependencies and remove stale ones
40f8e62
to
dd4bc13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update: So I think this go.mod hadnt been updated since it moved from andrew's repo over here.
so I made a fresh go.mod, fixed some import errors in main.go and fixed a go fmt missing operand.
also renamed the (incorrectly named) ign2to3 to ignconverter