Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Remount /sysroot rw #38

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Remount /sysroot rw #38

merged 3 commits into from
Jan 9, 2019

Conversation

thkukuk
Copy link
Contributor

@thkukuk thkukuk commented Jan 9, 2019

Some Linux Distributions don't pass a rw option on the kernel commandline
and thus mount the root filesystem ro by default. In this case, remount
/sysroot to rw (issue #37)

Some Linux Distributions don't pass a rw option on the kernel commandline
and thus mount the root filesystem ro by default. In this case, remount
/sysroot to rw (issue #37)
@dustymabe
Copy link
Member

Any chance we could get the comment from your commit message at the top of the systemd unit as a comment there?

@thkukuk
Copy link
Contributor Author

thkukuk commented Jan 9, 2019

Ok, I have added the comment there, too.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, just one typo.

@@ -6,6 +6,10 @@ DefaultDependencies=false
Requires=initrd-root-fs.target
After=initrd-root-fs.target

# Make sure root filesysem is mounted read-write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/filesysem/filesystem/

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

@thkukuk do you want to squash your commits into one or should I do it using the Github web UI?

@thkukuk
Copy link
Contributor Author

thkukuk commented Jan 9, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants