This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Linux Distributions don't pass a rw option on the kernel commandline and thus mount the root filesystem ro by default. In this case, remount /sysroot to rw (issue #37)
Any chance we could get the comment from your commit message at the top of the systemd unit as a comment there? |
Ok, I have added the comment there, too. |
jlebon
reviewed
Jan 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me, just one typo.
@@ -6,6 +6,10 @@ DefaultDependencies=false | |||
Requires=initrd-root-fs.target | |||
After=initrd-root-fs.target | |||
|
|||
# Make sure root filesysem is mounted read-write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/filesysem/filesystem/
dustymabe
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thkukuk do you want to squash your commits into one or should I do it using the Github web UI? |
On Wed, Jan 09, Dusty Mabe wrote:
@thkukuk do you want to squash your commits into one or should I do it using
the Github web UI?
Please do it via the github web UI, else it will take ages until I get it
done correctly ...
…--
Thorsten Kukuk, Distinguished Engineer, Senior Architect SLES & MicroOS
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany
GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Linux Distributions don't pass a rw option on the kernel commandline
and thus mount the root filesystem ro by default. In this case, remount
/sysroot to rw (issue #37)