internal/providers: Run platform Init function before fetching config #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft while untested |
arithx
force-pushed
the
s3_config_fix
branch
4 times, most recently
from
b439c5b
to
eea87aa
Compare
bgilbert
reviewed
Dec 23, 2020
This function has been dead since 198184c.
|
Re second commit message, let's drop |
The value of initialBackoff is increased before the wait is ever performed. This means that we never actually wait for the default initialBackoff time. Move it to after the wait but also increase the current default to mirror what was happening with the previous functionality.
|
Updated & marking ready for review. |
arithx
force-pushed
the
s3_config_fix
branch
2 times, most recently
from
81826a2
to
91f8428
Compare
On AWS we need to run the platform-specific Init function before we fetch the configuration. This Init function is attempting to fetch the S3RegionHint which we need to set to the proper value before attempting to fetch any S3 resources (the region hint defaults to us-east-1 which would cause failures when running EC2 instances in non-standard partitions that are attempting to fetch merge / replacement configurations from S3 resources). Fixes [RHBZ 1892521](https://bugzilla.redhat.com/show_bug.cgi?id=1892521) Fixes [RHBZ 1902996](https://bugzilla.redhat.com/show_bug.cgi?id=1902996)
bgilbert
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AWS we need to run the platform-specific Init function before we
fetch the configuration. This Init function is attempting to fetch the
S3RegionHint which we need to set to the proper value before attempting
to fetch any S3 resources (the region hint defaults to us-east-1 which
would cause failures when running EC2 instances in non-standard
partitions that are attempting to fetch merge / replacement
configurations from S3 resources).
Fixes RHBZ 1892521
Fixes RHBZ 1902996