Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sgdisk: Run partx after partition changes #1717
base: main
Are you sure you want to change the base?
sgdisk: Run partx after partition changes #1717
Changes from all commits
8916185
c2cc56c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit heavy to parse
/proc/mounts
on every block device. Ideally, we'd do this once. In practice, I don't think it matters too much.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there shouldn't be millions of mount points in the initrd - if that ever is the case it can be cached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is that the canonical way to get disk partitions? I wonder how libblkid does it. Which actually, we do link to it in Ignition.
So another way to get this info is to use e.g.
getPartitionMap()
in this file which calls out to libblkid. But I think that function assumes that the passed device is a disk so it wouldn't work when recursing into the partition inblockDevInUse()
. But we could also restructureblockDevInUse()
so that the held and mounted checks are their own functions and then not recurse (which anyway feels a bit like a weird thing to do to avoid even looking for partitions on partitions).Not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't have time to investigate this idea and will leave it as is