This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
DrawTextFormatBar: nonsensical numbers could cause a panic #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a test case? |
added 2 commits
October 7, 2015 12:13
With a recent change ioprogress now checks if it's printing to a terminal and will use "\n" instead of "\r" if it is not. The tests were expecting ioprogress to print "\r"s, but since ioprogress is not printing to a terminal that was no longer the case
If one of the numbers provided to draw the progress bar was nonsensical, like the total download size being 0, the library would cause a panic. This adds a check for a unexpected current progress, and will display an empty bar if it's outside acceptable bounds.
jonboulle
added a commit
that referenced
this pull request
Oct 23, 2015
DrawTextFormatBar: nonsensical numbers could cause a panic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the numbers provided to draw the progress bar was nonsensical,
like the total download size being 0, ioprogress would cause a panic.
This adds a check for a unexpected current progress, and will display an
empty bar if it's outside acceptable bounds.