This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Setup bare bone scripts for builds #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdahiya
force-pushed
the
bare-bones
branch
2 times, most recently
from
026bd22
to
9dc75f9
Compare
ericchiang
reviewed
Feb 9, 2018
There was a problem hiding this comment.
Just a couple nits, other than that lgtm
Once we get some Go code in here, please setup travis https://github.com/coreos/matchbox/blob/master/.travis.yml
Makefile
Outdated
|
|
||
| check: | ||
| @gofmt -l -s $(GOFILES) | read; if [ $$? == 0 ]; then gofmt -s -d $(GOFILES); exit 1; fi | ||
| @go vet $(shell go list ./... | grep -v '/vendor/') |
There was a problem hiding this comment.
nit: go list ./... doesn't match vendor anymore https://golang.org/doc/go1.9#vendor-dotdotdot
Makefile
Outdated
| @gofmt -l -s $(GOFILES) | read; if [ $$? == 0 ]; then gofmt -s -d $(GOFILES); exit 1; fi | ||
| @go vet $(shell go list ./... | grep -v '/vendor/') | ||
| @./scripts/verify-gopkg.sh | ||
| @go test -v $(shell go list ./... | grep -v '/vendor/\|/e2e') |
abhinavdahiya
force-pushed
the
bare-bones
branch
from
9dc75f9
to
b59676a
Compare
ericchiang
approved these changes
Feb 9, 2018
abhinavdahiya
pushed a commit
to abhinavdahiya/kubecsr
that referenced
this pull request
Jul 12, 2019
OWNERS: init
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc: @ericchiang