This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Bug 1797153: pkg/certagent: add support for passing escaped IPv6 addresses #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
/cc @abhinavdahiya |
hexfusion
referenced
this pull request
in openshift/cluster-etcd-operator
Jan 3, 2020
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
Looks good to me. Although it may be useful to move the |
|
Yeah at some point the logic will exist where it can be useful for other projects but for now this is the path of least resistance. |
|
/lgtm |
|
/cc @abhinavdahiya |
hexfusion
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for kube-client-agent to unescape IPv6 addresses. For example passing
--ipaddrs=[::1]would currently fail as this is not a valid IPv6 address. The reason we want this ability is to simplify IPv6 validation as we do not need to worry about changing the format of the address before passing it to the agent. If the underlying IPv6 address is validkube-client-agentwill do the right thing and handle unescaping for free./cc @retroflexer @russellb @alaypatel07