This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
*: Modified to conform to Module aware 'go list' #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes etcd-io/etcd#11132 |
|
@gyuho PTAL |
|
Does this fix the issue? /cc @philips |
|
can you update the commit message of 038a5eb to include some details on what this change is and why it was necessary for go 1.13 Here is an example of a good commit message from this repo: 55ffe16 Some more context: |
|
@philips thanks for the comment. Updated the commit message. |
Go 1.13 is module aware, so the output of 'go list' results in paths pointing to module cache (GOPATH/pkg/mod). Non module aware go versions, the `Root` field in the `go list` output contains `GOPATH`. In module aware Go versions, it points to the root of module in module cache. Earlier versions, the LICENSEs could be read by concatenating the `GOPATH` and `ImportPath` fields. Now the LICENSES need to be read by using `Root` and `Dir` fields which point to the root of the module and imported folder within the module. This change fixes bill-of-materials test fails in etcd CI with Go 1.13. etcd-io/etcd#11132
vimalk78
changed the title
|
LGTM, go for it. |
|
can this PR be merged? |
|
thanks @philips !! |
vimalk78
added a commit
to vimalk78/etcd
that referenced
this pull request
Sep 14, 2019
bill-of-materials was fixed for module aware 'go list' as part of coreos/license-bill-of-materials#17 So can re enable bom tests fixes etcd-io#11132
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified to use go1.13