This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
systemd: run After update_engine #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d01a4c3 dropped a Requires/After on update-engine.service, since those would prevent systemd from restarting locksmithd if update-engine failed. However, that change created a race in which locksmithd would start before update_engine, fail with Cannot get update engine status: The name com.coreos.update1 was not provided by any .service files and be restarted by systemd 10 seconds later. Ideally update_engine would support bus activation, but enabling that would require users to take an additional step when disabling update_engine, breaking backward compatibility. Instead, add an After to fix the race, but do not pull in update_engine. In principle we could also add a Wants, but that would change behavior in a corner case (restarting locksmithd with update_engine stopped).
euank
approved these changes
Oct 9, 2017
|
Good to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d01a4c3 dropped a
Requires/Afteron update-engine.service, since those would prevent systemd from restarting locksmithd if update-engine failed. However, that change created a race in which locksmithd would start before update_engine, fail withand be restarted by systemd 10 seconds later.
Ideally update_engine would support bus activation, but enabling that would require users to take an additional step when disabling update_engine, breaking backward compatibility. Instead, add an After
to fix the race, but do not pull in update_engine. In principle we could also add a
Wants, but that would change behavior in a corner case (restarting locksmithd with update_engine stopped).