platform/api/azure: update GC to delete old bootdiagnostics

Currently a bootdiagnostic container is generated for every instance,
this extends the current Azure GC command to also delete these from
the kola storage account.

platform/api/azure/api.go

@@ -100,29 +100,53 @@ func randomName(prefix string) string {
 }
 
 func (a *API) GC(gracePeriod time.Duration) error {
-	list, err := a.ListResourceGroups("")
+	durationAgo := time.Now().Add(-1 * gracePeriod)
+
+	listGroups, err := a.ListResourceGroups("")
 	if err != nil {
-		return err
+		return fmt.Errorf("listing resource groups: %v", err)
 	}
 
-	durationAgo := time.Now().Add(-1 * gracePeriod)
-
-	for _, l := range *list.Value {
+	for _, l := range *listGroups.Value {
 		if strings.HasPrefix(*l.Name, "kola-cluster") {
 			createdAt := *(*l.Tags)["createdAt"]
 			timeCreated, err := time.Parse(time.RFC3339, createdAt)
 			if err != nil {
 				return fmt.Errorf("error parsing time: %v", err)
 			}
-			if timeCreated.After(durationAgo) {
-				return fmt.Errorf("skipping resource group %s due to being too new", *l.Name)
-			} else {
+			if !timeCreated.After(durationAgo) {
 				if err = a.TerminateResourceGroup(*l.Name); err != nil {
 					return err
 				}
 			}
 		}
 	}
 
+	kr, err := a.GetStorageServiceKeysARM("kola")
+	if err != nil {
+		return fmt.Errorf("fetching storage service keys: %v", err)
+	}
+
+	for _, k := range *kr.Keys {
+		listContainers, err := a.ListStorageContainers("kola", *k.Value, "bootdiagnostics-kola")
+		if err != nil {
+			return fmt.Errorf("listing storage containers: %v", err)
+		}
+
+		for _, l := range listContainers.Containers {
+			timeModified, err := time.Parse(time.RFC1123, l.Properties.LastModified)
+			if err != nil {
+				return fmt.Errorf("error parsing time: %v", err)
+			}
+			if !timeModified.After(durationAgo) {
+				if err = a.TerminateStorageContainer("kola", *k.Value, l.Name); err != nil {
+					return err
+				}
+			}
+		}
+
+		break
+	}
+
 	return nil
 }

platform/api/azure/storage_mit.go

@@ -42,6 +42,30 @@ const pageBlobPageSize int64 = 2 * 1024 * 1024
 
 type BlobExistsError string
 
+func (a *API) ListStorageContainers(storageaccount, storagekey, prefix string) (storage.ContainerListResponse, error) {
+	sc, err := storage.NewClient(storageaccount, storagekey, a.opts.StorageEndpointSuffix, storage.DefaultAPIVersion, true)
+	if err != nil {
+		return storage.ContainerListResponse{}, err
+	}
+
+	bsc := sc.GetBlobService()
+
+	return bsc.ListContainers(storage.ListContainersParameters{
+		Prefix: prefix,
+	})
+}
+
+func (a *API) TerminateStorageContainer(storageaccount, storagekey, name string) error {
+	sc, err := storage.NewClient(storageaccount, storagekey, a.opts.StorageEndpointSuffix, storage.DefaultAPIVersion, true)
+	if err != nil {
+		return err
+	}
+
+	bsc := sc.GetBlobService()
+
+	return bsc.DeleteContainer(name)
+}
+
 func (be BlobExistsError) Error() string {
 	return fmt.Sprintf("blob %q already exists", string(be))
 }