This repository has been archived by the owner on May 7, 2021. It is now read-only.
platform/api/aws: copy createVolumePermission when replicating #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should just match whatever permissions are set on the source snapshot. Closes: coreos#1111
jlebon
force-pushed
the
pr/ore-copy-aws
branch
from
24e7a30
to
f59827a
Compare
|
Ahh, so at least with FCOS, this'll require broadening permissions: |
cgwalters
approved these changes
Oct 24, 2019
|
Still testing for RHCOS. Will file an issue to get permissions extended for FCOS. |
|
OK, this is working fine! I couldn't test FCOS, but I filed https://pagure.io/fedora-infrastructure/issue/8325. |
jlebon
added a commit
to jlebon/fedora-coreos-pipeline
that referenced
this pull request
Oct 24, 2019
We need this for the new mantle code that replicates AMIs: coreos/mantle#1112
jlebon
added a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Oct 24, 2019
We need this for the new mantle code that replicates AMIs: coreos/mantle#1112
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should just match whatever permissions are set on the source
snapshot.
Closes: #1111