This repository has been archived by the owner on May 7, 2021. It is now read-only.
kola/tests: add nested partitions and raid test #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgilbert
approved these changes
Aug 31, 2017
kola/tests/misc/raid.go
Outdated
| Run: NestedRootOnRaid, | ||
| ClusterSize: 0, | ||
| Platforms: []string{"qemu"}, | ||
| MinVersion: semver.Version{Major: 1520}, |
There was a problem hiding this comment.
Will need to be updated, of course.
There was a problem hiding this comment.
1534 good? It's dependent on Ignition changes (which will require a ignition bump in the overlay).
There was a problem hiding this comment.
Seems like a reasonable guess. If it turns out to be wrong, the test will start failing and we'll bump again.
kola/tests/misc/raid.go
Outdated
| nestedRaidRootUserData = conf.ContainerLinuxConfig(`storage: | ||
| disks: | ||
| - device: /dev/vdb | ||
| wipe_table: true |
There was a problem hiding this comment.
None of the wipe_tables should be necessary here.
kola/tests/misc/raid.go
Outdated
| @@ -80,6 +152,18 @@ func init() { | |||
| Name: "coreos.disk.raid.root", | |||
| }) | |||
| register.Register(®ister.Test{ | |||
| // This test needs additional disks which is only supported on qemu since Ignition | |||
| // does not support creating partitions on disks without wiping the partition table | |||
ajeddeloh
force-pushed
the
root-raid-nested
branch
from
0b2e509
to
138e4f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on coreos/ignition#434