You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt fetch/run always fails when an ACI compressed with xz.
$ rkt version
rkt version 0.7.0
appc version 0.6.1
$ sudo rkt --insecure-skip-verify fetch test.aci
error copying image: exit status 1
I found a commit that caused this issue using git-bisect. 7fbfb35
This commit adds code that calling aci.ManifestFromImage before calling WriteACI.
ManifestFromImage reads ACI file partially.
Currently, XZ decompressor implementation is executing xz command at goroutine.
ManifestFromImage partially reads ACI file.
But xz command is still executing after ManifestFromImage exited.
Therefore, file position is changed by xz command that was executed at ManifestFromImage, and cannot read begining of file at WriteACI.
The text was updated successfully, but these errors were encountered:
@kazuki Thanks for your report and analysis! I can reproduce this easily with a quite big ACI having the manifest at the start of the tar as this helps keeping more than one xz process running.
I'm testing some patches (for both appc/spec and rkt) that should fix this. I also discovered another bug while looking at this. I'll link the related PRs here when ready.
The interface for aci.NewCompressedReader changed in the upstream appc
code (appc/spec#462) to return a ReadCloser
instead of a Reader. Hence it's now our responsibility to close the
returned ACI.
Fixesrkt#1224
rkt fetch/run always fails when an ACI compressed with xz.
I found a commit that caused this issue using git-bisect.
7fbfb35
This commit adds code that calling aci.ManifestFromImage before calling WriteACI.
ManifestFromImage reads ACI file partially.
Currently, XZ decompressor implementation is executing xz command at goroutine.
ManifestFromImage partially reads ACI file.
But xz command is still executing after ManifestFromImage exited.
Therefore, file position is changed by xz command that was executed at ManifestFromImage, and cannot read begining of file at WriteACI.
The text was updated successfully, but these errors were encountered: