This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
docs: added benchmarks folder, benchmarks for v1.4.0 #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Identical (aside from PID) worker-binary lines removed | ||
| worker-binary(24029): seconds alive: 18 avg CPU: 0.000000% avg Mem: 840 kB peak Mem: 840 kB | ||
| worker-binary(23691): seconds alive: 19 avg CPU: 0.000000% avg Mem: 840 kB peak Mem: 840 kB | ||
| rkt(23316): seconds alive: 23 avg CPU: 9.484321% avg Mem: 5 mB peak Mem: 20 mB |
There was a problem hiding this comment.
Why are there two rkt processes?
There was a problem hiding this comment.
No clue. I also can't seem to reproduce those results after rerunning this a handful of times. Here's output from when I ran it again, want me to swap the text in the PR with this?
derek@proton ~/go/src/github.com/coreos/rkt/tests/rkt-monitor> sudo ./rkt-monitor too-many-apps.podmanifest -d 30s
# Identical (aside from PID) worker-binary lines removed
rkt(17227): seconds alive: 20 avg CPU: 9.595387% avg Mem: 3 mB peak Mem: 20 mB
systemd(17253): seconds alive: 17 avg CPU: 0.329028% avg Mem: 16 mB peak Mem: 16 mB
systemd-journal(17255): seconds alive: 17 avg CPU: 0.000000% avg Mem: 6 mB peak Mem: 6 mB
worker-binary(17883): seconds alive: 17 avg CPU: 0.000000% avg Mem: 840 kB peak Mem: 840 kB
Added the `Documentation/benchmarks` folder which includes a README that describes how rkt-monitor works and how to use it, and a file detailing the results of running rkt-monitor on each current workload with rkt v1.4.0.
|
Looks fine for now, we can iterate. |
|
Brazenly ignoring CI for this docs-only change. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
Documentation/benchmarksfolder which includes a README thatdescribes how rkt-monitor works and how to use it, and a file detailing
the results of running rkt-monitor on each current workload with rkt
v1.4.0.
Fixes #1788