Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

docs: use stageX consistently #2699

Merged
merged 1 commit into from
May 26, 2016
Merged

docs: use stageX consistently #2699

merged 1 commit into from
May 26, 2016

Conversation

matthaias
Copy link
Contributor

jonboulle
jonboulle reviewed May 26, 2016
View reviewed changes
tests/rkt_ace_validator_test.go
@@ -74,10 +74,10 @@ func TestAceValidator(t *testing.T) {
}
aceStage := results[1]
if _, ok := set[aceStage]; ok {
Copy link
Contributor

@jonboulle jonboulle May 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file should be reverted, it's referencing a different stage concept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it.

@jonboulle
Copy link
Contributor

Thanks for the patch, although now that I'm seeing this change everywhere I'm not sure how much I like it. Would be good to get some others' opinions.

@matthaias matthaias force-pushed the docs-use-stageX-consistently branch from 3d41ad1 to d708710 Compare May 26, 2016 09:47
@matthaias
Copy link
Contributor Author

Sure, let's wait for other opinions.

@lucab
Copy link
Member

lucab commented May 26, 2016

I actually like it, I would only leave out of this: a) chapter titles in architecture.md b) labels for the two numbered lists in stage1-implementors-guide.md - as they are meant to introduce to (space-style) stages separation.

@jonboulle
Copy link
Contributor

SGTM

On Thu, May 26, 2016 at 12:12 PM, Luca Bruno notifications@github.com
wrote:

I actually like it, I would only leave out of this: a) chapter titles in
architecture.md b) labels for the two numbered lists in
stage1-implementors-guide.md - as they are meant to introduce to
(space-style) stages separation.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2699 (comment)

@matthaias matthaias force-pushed the docs-use-stageX-consistently branch from d708710 to 39bb4eb Compare May 26, 2016 14:32
@matthaias matthaias force-pushed the docs-use-stageX-consistently branch from 39bb4eb to 1d40da6 Compare May 26, 2016 14:34
@matthaias
Copy link
Contributor Author

@lucab PTAL, i hope i did what your meant :)

@lucab
Copy link
Member

lucab commented May 26, 2016

Yes, definitely. LGTM, thanks.

@lucab lucab merged commit 18b1483 into rkt:master May 26, 2016
@matthaias matthaias deleted the docs-use-stageX-consistently branch May 26, 2016 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/cleanup kind/documentation reviewed/lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthaias @jonboulle @lucab