This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
common: remove unused GetImageIDs() #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes apps.GetImageIds() method as it has no callers anymore. This helper was added to pass list of image ids to the state0, but now we pass list of apps in a pod instead. Last user of the GetImageIDs() was removed in the 227fe3c commit ( Move pod registration from stage1 to stage0. by @eyakubovich ) and it is not used anywhere anymore. So we can remove it.
|
Good catch! |
|
Can one of the admins verify this patch? |
|
ok to test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes apps.GetImageIds() method as it has no callers anymore.
This helper was added to pass list of image ids to the state0, but now we
pass list of apps in a pod instead.
Last user of the GetImageIDs() was removed in the 227fe3c commit
( Move pod registration from stage1 to stage0. by @eyakubovich ) and it is
not used anywhere anymore.
So we can remove it.