This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
cgroup/v1: introduce mount flags to mountFsRO #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently mount flags are lost when remounting a mountpoint read-only. This changes it such that mountFsRO takes a flags parameter, and adds MS_BIND, MS_REMOUNT, MS_RDONLY. Fixes rkt#3286
s-urbaniak
force-pushed
the
3286-mountflags
branch
from
8a11377
to
d2a9918
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mount flags are lost when remounting a mountpoint read-only.
This changes it such that mountFsRO takes a flags parameter, and adds
MS_BIND, MS_REMOUNT, MS_RDONLY.
Fixes #3286