Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebasing back from container to pure ostree fails #3677

Closed
cgwalters opened this issue May 12, 2022 · 1 comment · Fixed by #3680
Closed

rebasing back from container to pure ostree fails #3677

cgwalters opened this issue May 12, 2022 · 1 comment · Fixed by #3680

Comments

@cgwalters
Copy link
Member

# rpm-ostree rebase --experimental ostree-unverified-registry:quay.io/coreos-assembler/fcos:stable
...
# rpm-ostree rebase fedora:fedora/x86_64/coreos/testing-devel
error: Invalid refspec ostree-unverified-registry:quay.io/coreos-assembler/fcos:stable

This is a bug in the rebase code, we shouldn't be trying to interpret the prior refspec as ostree.

@lucab
Copy link
Contributor

lucab commented May 13, 2022

I took some time to identify where this is coming from, and it looks like the error is originating here:

/* The rest of the code assumes TYPE_OSTREE refspec */
g_autofree gchar *new_refspec = NULL;
if (!rpmostreed_refspec_parse_partial (refspec, current_refspec.refspec.c_str (), &new_refspec,
error))
return FALSE;

And we are reaching there through this:
if (self->refspec != NULL)
{
if (!change_origin_refspec (NULL, sysroot, origin, self->refspec, cancellable, NULL, NULL,
error))
return FALSE;
}

@lucab lucab added the bug label May 13, 2022
cgwalters added a commit to cgwalters/rpm-ostree that referenced this issue May 15, 2022
Since the container flow is experimental, we need to handle
rebasing back to ostree.

There's still an issue here in that we're not pruning container image
refs when rebasing, but that's also true of rebasing between
container images today.

Closes: coreos#3677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants