Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm 4.19-built RPMs contain non-root ownership in cpio stream again, breaking imports #4437

Closed
dustymabe opened this issue May 26, 2023 · 7 comments · Fixed by #4455
Closed

rpm 4.19-built RPMs contain non-root ownership in cpio stream again, breaking imports #4437

dustymabe opened this issue May 26, 2023 · 7 comments · Fixed by #4455
Labels
triaged This issue was triaged

Comments

@dustymabe
Copy link
Member

dustymabe commented May 26, 2023 •
edited by cgwalters

EDIT: Updated issue description by @cgwalters

rpm-software-management/rpm@0f95733 causes our sanity checking in the importer to fail (unified core mode).

We'll need to adjust it to handle this.

Original issue text:

The new util-linux-2.39-4.fc39 build seems to be causing cosa fetch to fail with:

[2023-05-26T12:43:13.524Z] Input state hash: 90cd7469b44fea7104cd121e7707214fbc8b3fb77801af1041719cd29e771638
[2023-05-26T12:43:13.524Z] Will download: 426 packages (520.3?MB)
[2023-05-26T12:43:16.045Z] Downloading from 'fedora-rawhide'...done
[2023-05-26T12:43:31.059Z] error: importing RPMs: Importing package 'util-linux': Analyzing /usr/bin/write: Unexpected non-root owned path (marked as 0:5)

We'll pin on the previous version for now while we work out the details.
@djds djds mentioned this issue May 28, 2023
Closed
djds referenced this issue in djds/fedora-coreos-config May 28, 2023
@djds
Pin util-linux to 2.38.1-4.fc38
e946afb 
https://github.com/coreos/fedora-coreos-tracker/issues/1501
@karelzak
Copy link

Not sure, I do not see any change in write(1) rights

spec file (rawhide with v2.39):
%attr(2755,root,tty) %{_bindir}/write

on disk (f36 with v2.38):
-rwxr-sr-x 1 root tty 24544 Jun 1 2022 /usr/bin/write

@travier
Copy link
Member

travier commented May 31, 2023

I see this failing in my test OCI desktop builds (https://gitlab.com/fedora/ostree/ci-test/-/jobs/4380329463) but not in Fedora Infra so this looks like a unified-core specific issue

@travier
Copy link
Member

travier commented May 31, 2023

My builds uses the latest rpm-ostree from the continuous repo and only Rawhide started failing, F38 & F37 still build, pointing to an issue specific to the Rawhide package.

@dustymabe
Copy link
Member Author

There were a bunch of RPM changes that landed recently. I'm wondering if it is somehow an artifact of how the util-linux RPM was built (using the new RPM in rawhide) and other RPMs as they get built over time will start to show a similar problem.

@cgwalters cgwalters transferred this issue from coreos/fedora-coreos-tracker May 31, 2023
@cgwalters cgwalters changed the title rawhide: cosa fetch fails to import util-linux-2.39-4.fc39 rpm 4.19-built RPMs contain non-root ownership in cpio stream again, breaking imports May 31, 2023
@cgwalters
Copy link
Member

There were a bunch of RPM changes that landed recently. I'm wondering if it is somehow an artifact of how the util-linux RPM was built (using the new RPM in rawhide)

Indeed it is.

I transferred this issue to rpm-ostree as it affects multiple things, and edited the top issue text with more details.

cgwalters added a commit to cgwalters/rpm-ostree that referenced this issue Jun 9, 2023
@cgwalters
importer: Drop non-root files in CPIO check
8420d46 
rpm upstream did
rpm-software-management/rpm@0f95733

The file metadata is still duplicated in the header, and *that*
seems unlikely to change soon.  So we can just safely drop
this "sanity check".

Closes: coreos#4437
@cgwalters cgwalters mentioned this issue Jun 9, 2023
Merged
@cgwalters cgwalters added the triaged This issue was triaged label Jun 9, 2023
cgwalters added a commit that referenced this issue Jun 11, 2023
@cgwalters
importer: Drop non-root files in CPIO check
cc7292d 
rpm upstream did
rpm-software-management/rpm@0f95733

The file metadata is still duplicated in the header, and *that*
seems unlikely to change soon.  So we can just safely drop
this "sanity check".

Closes: #4437
lukewarmtemp pushed a commit to lukewarmtemp/rpm-ostree that referenced this issue Aug 8, 2023
@cgwalters @lukewarmtemp
importer: Drop non-root files in CPIO check
c09a081 
rpm upstream did
rpm-software-management/rpm@0f95733

The file metadata is still duplicated in the header, and *that*
seems unlikely to change soon.  So we can just safely drop
this "sanity check".

Closes: coreos#4437
@bam80
Copy link

bam80 commented Mar 6, 2024

Any workaround for those upgrading to SB 38?

$ rpm-ostree rebase fedora:fedora/38/x86_64/silverblue
...
error: importing RPMs: Importing package 'kf5-kdesu': Analyzing /usr/libexec/kf5/kdesud: Unexpected non-root owned path (marked as 0:65534)

@jlebon
Copy link
Member

jlebon commented Mar 6, 2024

@bam80 You should be able to rpm-ostree reset, then rpm-ostree rebase, reboot, and then re-add your layered packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged This issue was triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

importer: Drop non-root files in CPIO check cgwalters/rpm-ostree
6 participants
@bam80 @cgwalters @karelzak @dustymabe @jlebon @travier