Prep patches for compose tests rework #1960
Conversation
The parent of a `Path` of `"foobar"` is actually `""`, because `parent()` wants to return a slice of its buffer: rust-lang/rust#36861 Just do a trivial wrapper around it to correctly return `"."` instead. Hit this when trying to pass a treefile in the working directory.
We were trying to unref a `GHashTable` using `g_ptr_array_unref`. Something something... rewrite it in Rust.
No reason we can't do this. I initially was going to make use of this for tests, but ended up not needing it.
So that we keep `stdout` clean. This is important for `--print-only`.
Let's make that explicit to make it easier to debug. (This works because right now, we auto-create the spec file on the Rust side at parse time.)
This helper is used for both JSON and YAML treefiles now.
We don't need any privs for just downloading the RPMs.
jlebon
force-pushed
the
pr/compose-cci-prep
branch
from
ee20644
to
12c7d30
Compare
This makes it easier to flatten a treefile. To do this, we make having a workdir optional on the Rust side, and on the C side, just move `--print-only` handling up front.
jlebon
force-pushed
the
pr/compose-cci-prep
branch
from
12c7d30
to
23ee693
Compare
This is in el8 now.
We definitely want this too.
| @@ -2,7 +2,7 @@ | |||
| set -euo pipefail | |||
|
|
|||
| # this corresponds to the latest Rust module available in el8 | |||
| MINIMUM_SUPPORTED_RUST_VERSION=1.37.0 | |||
| MINIMUM_SUPPORTED_RUST_VERSION=1.39.0 | |||
|
@jlebon: GitHub didn't allow me to request PR reviews from the following users: FYI. Note that only coreos members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Awesome! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override f29-compose1 |
|
@jlebon: Overrode contexts on behalf of jlebon: f29-compose1, f29-compose2 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Split out of #1959.
Most of those are actually not technically required anymore for #1959, but I've been working on top of them.