Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Mark all repos as "modular hotfixes" #1961

Merged
merged 1 commit into from Jan 9, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jan 8, 2020

This is a follow-up hack to #1797 to force libdnf to let us use modular
packages as if they were regular packages until we actually support
modules correctly (#1435).

A repo marked as a modular hotfix means that libdnf doesn't try to
filter out modular RPMs from the repo as it usually does.

Resolves: https://pagure.io/releng/failed-composes/issue/717

@jlebon
Copy link
Member Author

jlebon commented Jan 8, 2020

I wrote this on top of #1959 so we have CI coverage, but I can split it out if we're not ready to merge that one yet.

@jlebon
Copy link
Member Author

jlebon commented Jan 8, 2020

To clarify, I'm not super happy with this. Another approach I was tempted to do was going the opposite way and disabling modules entirely. We couldn't do this before because FCOS used modules for a few of its Rust packages, but those have been demodularized now. (But then we'll want to make sure we address #1435 before the need to include modules comes up again.)

This is a follow-up hack to coreos#1797 to force libdnf to let us use modular
packages as if they were regular packages until we actually support
modules correctly (coreos#1435).

A repo marked as a modular hotfix means that libdnf doesn't try to
filter out modular RPMs from the repo as it usually does.

Resolves: https://pagure.io/releng/failed-composes/issue/717
@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2966afe into coreos:master Jan 9, 2020
@jlebon
Copy link
Member Author

jlebon commented Jan 27, 2020

Note follow-up to this at: rpm-software-management/libdnf#885

@jlebon jlebon deleted the pr/modular-hotfixes branch April 23, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants