Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump anyhow from 1.0.32 to 1.0.33 in /rust #2253

Merged
merged 6 commits into from
Oct 14, 2020
Merged

build(deps): bump anyhow from 1.0.32 to 1.0.33 in /rust #2253

merged 6 commits into from
Oct 14, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps anyhow from 1.0.32 to 1.0.33.

Release notes

Sourced from anyhow's releases.

1.0.33

  • Clarify documentation of anyhow!, bail!, ensure! macros (#114)
Commits
  • 840afd8 Release 1.0.33
  • f9d7516 Merge pull request #114 from dtolnay/macrodoc
  • bcdec88 Link from bail! and ensure! to anyhow!
  • ec15c61 Link from bail! and ensure! to anyhow::Error
  • 5ec6713 Call out that bail! and ensure! require anyhow::Error in the return type
  • 75f57ed Fix the expression that bail! and ensure! are equivalent to
  • 9a95ce8 Link from anyhow! to anyhow::Error
  • 693ca21 Mention std::error::Error specialization behavior of anyhow!
  • f27588e Indicate that anyhow! is not just for strings
  • 33894b6 Remove feature="std" inside code that is already feature="std"
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
build(deps): bump anyhow from 1.0.32 to 1.0.33 in /rust
4e78053 
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.32 to 1.0.33.
- [Release notes](https://github.com/dtolnay/anyhow/releases)
- [Commits](dtolnay/anyhow@1.0.32...1.0.33)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Oct 12, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon closed this Oct 13, 2020
@jlebon jlebon reopened this Oct 13, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@jlebon
Copy link
Member

jlebon commented Oct 13, 2020

/lgtm
/ok-to-test

@jlebon
tests/compose: Bump FCOS config commit to test
2661274 
We were composing f31, which has now been untagged from the pool now
that FCOS is working on moving to f33 (see
coreos/fedora-coreos-tracker#609 (comment)).

Bump the commit to test here (this is the HEAD of `testing-devel` at the
time of this writing).
@jlebon
Copy link
Member

jlebon commented Oct 13, 2020

Note I've added a commit here to fix CI. ⬆️

/lgtm

This was referenced Oct 13, 2020
Merged
Merged
@jlebon
Copy link
Member

jlebon commented Oct 13, 2020

Hmm interesting, a bunch of compose tests failed with:

FAIL: lockfile
   lockfile: Executing `postprocess` inline script '4'
   lockfile: chmod: cannot access '/etc/NetworkManager/dispatcher.d/20-coreos-chrony-dhcp': No such file or directory
   lockfile: chmod: cannot access '/usr/libexec/coreos-chrony-helper': No such file or directory
   lockfile: chmod: cannot access '/usr/lib/systemd/system-generators/coreos-platform-chrony': No such file or directory
   lockfile: �[31m�[1merror: �[22m�[0mPostprocessing: While executing inline postprocessing script '4': Executing bwrap(/usr/bin/rpmostree-postprocess-inline-4): Child process killed by signal 1
   lockfile: + rc=1

Not sure what's going on there.

@cgwalters
Copy link
Member

Me neither, I suspect something else is going wrong and this is just a confusing failure mode for it.

I submitted coreos/coreos-assembler#1786 related to this.

@cgwalters cgwalters mentioned this pull request Oct 13, 2020
Merged
@jlebon
Copy link
Member

jlebon commented Oct 13, 2020

Ahh I think I know what's going on here. The compose test doesn't have the bits from cosa that commits the overlays to the OSTree repo and injects it into the manifest. Fixing.

@cgwalters
Copy link
Member

The temptation to basically nuke most of our compose tests and all of the duplication/overlap we have with coreos-assembler is...powerful.

@jlebon
rust/treefile: Use shorthand initialization for Treefile
f19736a 
This lit up in my editor which does linting in the background.
@jlebon
tests/compose: Drop FCOS postprocess scripts
44322a6 
Now that we've bumped to the latest FCOS commit for compose tests, one
thing that came up was that our compose tests never actually included
FCOS overlays in the compose the way cosa does.

This then cause compose failures because one of the postprocess scripts
expects those files there.

Let's just nuke all postprocess scripts here to work around this. I
initially wanted to import the overlay logic from cosa, but overlays
only work in unified core mode, and sadly we still want some coverage in
non-unified mode until that's fully dropped.

And anyway, we also already do a proper `cosa build` in the vmcheck
branch of CI so it's not like we're losing that coverage.

Down the line though, I think this is a good argument for folding the
overlay dirs into rpm-ostree more natively as discussed here:

coreos/coreos-assembler#639 (comment)
cgwalters
cgwalters approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, dependabot-preview[bot], jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented Oct 13, 2020

The temptation to basically nuke most of our compose tests and all of the duplication/overlap we have with coreos-assembler is...powerful.

Yeah... though OTOH I think this would require making the cosa compose process more configurable (see original commit message in #1959).

@cgwalters
tests: Loosen regexp for French date
a6ff30f 
Something changed format, not sure what.
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@cgwalters cgwalters added the lgtm label Oct 14, 2020
@jlebon
tests/compose: Check filecaps of arping instead of ping
ee5a877 
In f32, ping is no longer privileged since it ships with the sysctl for
`ping_group_range` which allows unpriv pings. Check the file caps of
arping instead, which does still use them.
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@jlebon jlebon added the lgtm label Oct 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 821d2e1 into master Oct 14, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/cargo/rust/anyhow-1.0.33 branch October 14, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

@ashcrow ashcrow Awaiting requested review from ashcrow

@miabbott miabbott Awaiting requested review from miabbott

Assignees

@cgwalters cgwalters

@jlebon jlebon

Labels
approved dependencies Pull requests that update a dependency file lgtm ok-to-test rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-ci-robot @jlebon @cgwalters @openshift-merge-robot