status: Make --booted --json do the expected thing together
#4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
json-booted
branch
from
7a17f2c
to
12286a9
Compare
jlebon
previously approved these changes
Oct 14, 2022
|
Kola failure looks related. |
cgwalters
force-pushed
the
json-booted
branch
2 times, most recently
from
f14efc2
to
7418290
Compare
I'm almost certain this was a copy-paste mistake. This was really confusing to debug.
Unfortunately the implement involves some ugly grubbing through GVariant...really need to port this stuff to Rust. Closes: coreos#2829
cgwalters
force-pushed
the
json-booted
branch
from
fdd2d10
to
91ee54a
Compare
|
OK, this one is passing CI now. It's great when CI correctly finds bugs and you know it's working! |
lucab
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the implement involves some ugly grubbing through GVariant...really need to port this stuff to Rust.
Closes: #2829