Rework useradd(etc) sysusers integration to work in container flow #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
2 similar comments
|
/retest |
|
/retest |
lucab
reviewed
Oct 19, 2022
|
/retest |
|
OK! Got a passing Prow job here 🎉 |
cgwalters
force-pushed
the
useradd-container
branch
from
b8f7917
to
7da39db
Compare
First, right now our container flow doesn't use the "unified core" mode which means we aren't intercepting scripts. We hence can't set the environment variable which gives us the package name. Rework the sysusers file generation to not include the package name - in the end, while it is useful for debugging, in practice I don't think it's necessary. Next, if we're in a container build, turn on the sysusers.d interception by default. I think this is the default stance we should be taking now, and the container flow is a fresh new API. Finally, add support for `useradd -G` which is used by libvirt, e.g. https://src.fedoraproject.org/rpms/libvirt/blob/rawhide/f/libvirt.spec#_1621 `useradd -r -u 107 -g qemu -G kvm -d / -s /sbin/nologin -c "qemu user" qemu`
cgwalters
force-pushed
the
useradd-container
branch
from
7da39db
to
0636f8f
Compare
lucab
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, right now our container flow doesn't use the "unified core" mode which means we aren't intercepting scripts. We hence can't set the environment variable which gives us the package name.
Rework the sysusers file generation to not include the package name - in the end, while it is useful for debugging, in practice I don't think it's necessary.
Next, if we're in a container build, turn on the sysusers.d interception by default. I think this is the default stance we should be taking now, and the container flow is a fresh new API.
Finally, add support for
useradd -Gwhich is used by libvirt, e.g. https://src.fedoraproject.org/rpms/libvirt/blob/rawhide/f/libvirt.spec#_1621useradd -r -u 107 -g qemu -G kvm -d / -s /sbin/nologin -c "qemu user" qemu