Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "enable replacement" error text to "allow replacement" to match command-line interface #4869

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

ianloic
Copy link
Contributor

@ianloic ianloic commented Mar 11, 2024

I'm a very happy rpm-ostree user on Fedora Silverblue, but sometimes when I want to make a live change to my system with:

rpm-ostree install -A blah

I'll get an error message like:

error: packages would be changed: 34, enable replacement to override

and then I think oh, I have to pass that override so I do

sudo rpm-ostree apply-live --enable-replacement

but the argument is not --enable-replacement, it is in fact --allow-replacement.

This PR changes that error text to more closely match the correct command-line argument needed to override the error, so the error would now be:

error: packages would be changed: 34, allow replacement to override

It's subtle, but I think an ever so slight usability improvement.

Copy link

openshift-ci bot commented Mar 11, 2024

Hi @ianloic. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmarrero
Copy link
Member

/ok-to-test

@ianloic
Copy link
Contributor Author

ianloic commented Mar 11, 2024

/retest

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Thanks for the patch!

@jlebon jlebon merged commit 5441b8f into coreos:main Mar 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants