Rename "rpm" command to "db" #64
Conversation
|
With patches like this that involve lots of "code motion" and some cleanup, can you highlight what major semantic changes were made, if any? For cleanup I see moving _rpmostree_util_get_commit_hashes() into -util.c. Anything else? The patch looks good to me though. |
|
Sure, I split the "db diff/list/version" subcommands into separate files: Now rpmostree-builtin-db.c just does option parsing and command dispatching, like rpmostree-builtin-compose.c. I moved the support functions for the "db" subcommands to rpmostree-rpm-util.[ch]. Some functions that were "static" before are now exposed in the header file, not that it really matters. For _rpmostree_util_get_commit_hashes(), there's nothing rpm-specific about it so I moved it to rpmostree-util.c. Could potentially move that one into libostree someday. |
|
LGTM, feel free to squash and commit, thanks! |
Eliminates some confusion between "rpm-ostree rpm" (or "atomic rpm") commands versus actual "rpm" commands. The "rpm" subcommand is retained as a hidden alias for the "db" subcommand for backward-compatibility. It is not listed in --help output. Fixes #22
As a followup to renaming the "rpm" command to "db", split the "db" subcommands into separate source files in the style of "ostree admin" and "rpm-ostree compose". Also create rpmostree-rpm-util.[ch] as a place for common rpm-related functions needed by the "db" subcommands. No intentional functional changes here, just a bunch of copy-n-paste and minor cleanup.
This broke with coreos#64 I believe. The argument parsing here was rather hairy, and I think this patch clarifies things, in addition to fixing the bug.
Fixes issue #22 + some cleanup work on rpmostree-builtin-db.c
Note the "rpm-ostree rpm/db version" command is apparently broken atm, but I believe it's unrelated to these changes.