-
Notifications
You must be signed in to change notification settings - Fork 67
Terraform plan errors if tectonic_base_domain
is a variable
#7
Comments
This seems like a Terraform issue rather than an issue with this module :/ . Like you said, if you explicitly supply a string rather than a variable, the cluster builds. |
I've pulled down master of this module instead of the version from the module registry and the plan seems to pass. The changes in e50ed69#diff-230559a0d099ca913894ba9ea207acb3 to tectonic.tf seem to be what has fixed it. Incidentally, it takes a very long time (about 15 minutes) to run a |
@bodgit thanks for pointing this out. We will be releasing a new version within a week's time; that release will contain this change as well. As for the large download size, this is primarily a sub-optimal implementation issue in terraform, which should instead perform some type of sparse-checkout of git modules. That said, I am working on refactoring this module to eliminate this issue on our side. Could you update this issue, or open a new issue, to reflect this download size problem? |
Ok, I can probably run from master for now, not a problem.
Yeah, I figured Terraform could be a bit more intelligent with how it handles git downloads, especially if it sees multiple references to the same repository. I'll open another issue for the download size. |
I'm trying to test this out in an empty AWS account and given I had to create and supply the route53 zone name I figured I could do something like this:
However this results in the following error:
If I change my manifest to the below, then it works but there's now no guarantee that the zone would exist before the module needs it:
If I add an output that just returns the value of
${aws_route53_zone.tectonic.name}
then it returns a flat string exactly as it should so I'm not sure why it's exploding the way it is.This is with Terraform 0.10.8 and version 1.7.5-tectonic.1 of the module.
The text was updated successfully, but these errors were encountered: