Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhcos-toolbox: Update image_runlabel to newer podman format #67

Merged
merged 2 commits into from Jan 20, 2021
Merged

rhcos-toolbox: Update image_runlabel to newer podman format #67

merged 2 commits into from Jan 20, 2021

Conversation

travier
Copy link
Member

@travier travier commented Jan 15, 2021 •
edited

@travier travier changed the title WIP: rhcos-toolbox: Update image_runlabel to newer podman format rhcos-toolbox: Update image_runlabel to newer podman format Jan 15, 2021
@travier
Copy link
Member Author

travier commented Jan 15, 2021

Note that this most likely bumps the requirement for podman to version >=2.0

@miabbott
Copy link
Member

Locally tested fine in a cosa run session.

LGTM

@miabbott miabbott merged commit f61c747 into coreos:master Jan 20, 2021
mike-nguyen
mike-nguyen approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@mike-nguyen mike-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travier travier deleted the inspect branch January 21, 2021 15:10
@travier travier mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@mike-nguyen mike-nguyen mike-nguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@travier @miabbott @ashcrow @mike-nguyen