fix: add status page test for rule 921120 #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
dune73
previously approved these changes
Jan 9, 2023
|
Thank you @RedXanadu. This looks good. Ready to merge once tests are passing. |
|
This was a copy-paste of the Status Page test template. I don't understand why the GitHub actions are now failing. I've been using the same template since the Dev Retreat without issue. |
fzipi
changed the title
|
The failing test was on the title of the PR itself. Remember we are using conventional commits. So there is a test for that. 🤷 |
fzipi
reviewed
Jan 17, 2023
fzipi
requested changes
Jan 17, 2023
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
dune73
approved these changes
Jan 21, 2023
|
I've submitted your suggestion @fzipi so we can merge this. Yet GH wants you to approve first. Please approve and merge. |
fzipi
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a status page test for rule 921120 (a new test which only triggers this specific rule).